Skip to content

Model field name updates #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2019
Merged

Model field name updates #224

merged 1 commit into from
Aug 14, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Aug 6, 2019 •
edited
Loading

Update a few key names to cope with recent catapult-rest updates

tx change
AccountLink action -> linkAction
ModifyMultisig type -> modificiationType
AddressAlias action -> aliasAction
MosaicAlias action -> aliasAction
AccountRestriction type -> restrictionType

resolving issues: #215 #216

@rg911 rg911 requested a review from evias August 6, 2019 15:17
@coveralls
Copy link

coveralls commented Aug 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 598

  • 16 of 17 (94.12%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 60.446%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/Listener.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/service/AggregateTransactionService.ts 1 92.96%
Totals Coverage Status
Change from base Build 595: -0.008%
Covered Lines: 6362
Relevant Lines: 9095
💛 - Coveralls

@rg911 rg911 merged commit 7b91ea5 into symbol:master Aug 14, 2019
@rg911 rg911 deleted the task/g216_field_name_changed branch October 8, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias